Skip to content

Conversation

@Metloff
Copy link
Contributor

@Metloff Metloff commented Jul 6, 2019

Hello. I find one bug: intersection between Segment((0,0), (1,1)) and Ray((1,1), (4,4)) return nothing.
s = Segment((0,0), (1,1))
s.intersection(Ray((1,1), (4,4)))

References to other Issues or PRs

Brief description of what is fixed or changed

I fixed one condition in intersect_parallel_ray_and_segment method

Other comments

Release Notes

  • geometry
    • Fixed a bug with intersection segment and ray.

@sympy-bot
Copy link

sympy-bot commented Jul 6, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • geometry

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Hello. I find one bug: intersection between Segment((0,0), (1,1)) and Ray((1,1), (4,4)) return nothing.
`
s = Segment((0,0), (1,1))
`
`
s.intersection(Ray((1,1), (4,4)))
`
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
I fixed [one condition](https://github.com/sympy/sympy/blob/master/sympy/geometry/line.py#L461) in intersect_parallel_ray_and_segment method 

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* geometry
  * Fixed a bug with intersection segment and ray.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr
Copy link
Member

smichr commented Jul 6, 2019

Looks ok. Just needs a test and passing tests.

@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #17159 into master will increase coverage by 0.037%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           master    #17159       +/-   ##
============================================
+ Coverage    74.5%   74.537%   +0.037%     
============================================
  Files         623       623               
  Lines      161483    161536       +53     
  Branches    37896     37909       +13     
============================================
+ Hits       120305    120405      +100     
+ Misses      35843     35797       -46     
+ Partials     5335      5334        -1

@smichr smichr merged commit 0092ff3 into sympy:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants