Breaking up the Rational Factors #16527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sympy#16296. Breaks down the numerator and denominator of Rational factors in a multiplicative expression, fixing the denominator collection issue that collect_const() was having.
|
✅ Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
jksuom
reviewed
Apr 1, 2019
sympy/core/exprtools.py
Outdated
| # Handle all rational Coefficients | ||
| for f in list(factors.keys()): | ||
| if type(f) is Rational or type(f) is Half: | ||
| factors[f.p] = (factors[f.p] if f.p in factors else 0) + factors[f] |
Member
There was a problem hiding this comment.
Perhaps factors.set_default(f.p, 0) could be used.
Member
There was a problem hiding this comment.
f.p is a Python int. It should be converted into a SymPy Integer.
Abdullahjavednesar
added
core
PR: author's turn
jksuom
reviewed
Apr 2, 2019
Collaborator
|
The tests seem to be breaking right now so I guess something here isn't working right. This should have some new tests when it is working. |
Converting p, q to Sympy Integer and checking instance of Rational to fix the errors in tests.
jksuom
reviewed
Apr 6, 2019
All tests working now. Changed condition to Rational and Not integer when breaking up numberator and denominator.
Member
|
Please add a unit test. |
Testing factors directly and checking that collect_const can collect rationals.
jksuom
reviewed
Apr 7, 2019
Not evaulating Mul allows testing the collect_const function with Rational Factors.
AnimeshSinha1309
force-pushed
the
issue/collectconst-16296
branch
from
6e4c3c2 to
075f29f
Compare
Contributor
Author
|
Hope everything works well now, thanks a lot. |
jksuom
reviewed
Apr 8, 2019
Importing sympy.core.numbers.Half is no longer necessary.
Member
|
Thanks, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors()splits rational factors into its numerator and denominator.collect_const()can now collect the common dividing factors in an expression.References to other Issues or PRs
Fixes #16296
Brief description of what is fixed or changed
Breaks down the numerator and denominator of Rational factors in a multiplicative expression, fixing the denominator collection issue that collect_const() was having.
Release Notes