refraction_angle() now accepts inc. angle

[Trave11er]

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

• physics.optics
  • modified two functions in physics.optics.utils, namely: refraction_angle() and deviation() so they now also accept an angle of incidence. This is useful if the user wants to work the angles instead of inputting ray-like objects.

[sympy-bot]

✅

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• physics.optics
  • modified two functions in physics.optics.utils, namely: refraction_angle() and deviation() so they now also accept an angle of incidence. This is useful if the user wants to work the angles instead of inputting ray-like objects. (#16512 by @Trave11er)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.optics
   * modified two functions in `physics.optics.utils`, namely: `refraction_angle()` and `deviation()` so they now also accept an angle of incidence. This is useful if the user wants to work the angles instead of inputting ray-like objects.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[sidhantnagpal]

Can you resolve the conflicts? The tests won't begin until you do that.

[oscarbenjamin]

Looks like a straight-forward conflict (click the "resolve conflicts" button below). On master a couple of new tests were added on the same lines where you've added tests. Just edit so that all tests are there together and it should be fine. I think you can do this in the browser.

[Trave11er]

Thank you, @sidhantnagpal and @oscarbenjamin, for reviewing and providing tips on how to resolve the conflict. Have done that now - should be fine.

[oscarbenjamin]

Looks like you've sorted it correctly. The tests are running now...

[codecov]

Codecov Report

Merging #16512 into master will increase coverage by 0.071%.
The diff coverage is 74.358%.

@@             Coverage Diff              @@
##           master    #16512       +/-   ##
============================================
+ Coverage   73.74%   73.812%   +0.071%     
============================================
  Files         619       619               
  Lines      158623    159343      +720     
  Branches    37176     37388      +212     
============================================
+ Hits       116970    117615      +645     
- Misses      36237     36287       +50     
- Partials     5416      5441       +25

[Trave11er]

@oscarbenjamin please let me know if it needs more work on test coverage otherwise looks ripe to merge.

[Trave11er]

Thank you, @smichr for reviewing - have now incorporated all your suggestions.