Logic: algebraic normal form (Zhegalkin polynomial) #13686

konstantintogoi · 2017-12-07T00:37:29Z

logic
- Added a new normal form - ANFform. Function ANFform converts a list of truth values to an expression in Algebraic Normal Form (ANF).
- Added a new method BooleanFunction.to_anf that converts an expression to ANF by equivalent transformations.
- Added a new function is_anf that checks if an expression is ANF.
- Added a new function to_anf that converts an expression to ANF if it is not ANF.
- Added a new function distribute_xor_over_and. Given a sentence s consisting of conjunction and exclusive disjunctions of literals, it returns an equivalent exclusive disjunction.
- Added a new function bool_minterm that returns the k-th minterm of a fixed ordered set of binary variables.
- Added a new function bool_maxterm that returns the k-th maxterm of a fixed ordered set of binary variables.
- Added a new function bool_monomial that returns the k-th monomial of a fixed ordered set of binary variables.

sympy/logic/boolalg.py

gxyd

I haven't duplicated comments to similar requested changes, but please make those. Ex, use https:// prefix for links but I have made this comment only in one place.

sympy/logic/boolalg.py

gxyd · 2017-12-07T02:55:57Z

I would hope that we get code coverage in, otherwise it is difficult to see how much testing has been done.

gxyd · 2017-12-28T16:27:24Z

I think you have mistakenly changed the mode of sympy/logic/boolalg.py from 100644 -> 100755. Please remove that.

gxyd · 2017-12-28T16:42:06Z

Also for the test file, seems like you made it executable.

gxyd · 2017-12-28T16:51:47Z

sympy/logic/boolalg.py

Test case for this is missing.

This was refactored as

def to_anf(self, deep=True): args = range(1, len(self.args) + 1) args = (combinations(self.args, j) for j in args) args = chain.from_iterable(args) # powerset args = (And(*arg) for arg in args) args = map(lambda x: to_anf(x, deep=deep) if deep else x, args) return Xor(*list(args), remove_true=False)

And covered with tests

assert to_anf(Or(x, y)) == Xor(x, y, And(x, y)) assert to_anf(Or(Implies(x, y), And(x, y), y)) == \ Xor(x, True, x & y, remove_true=False) assert to_anf(Or(Nand(x, y), Nor(x, y), Xnor(x, y), Implies(x, y))) == True assert to_anf(Or(x, Not(y), Nor(x,z), And(x, y), Nand(y, z))) == \ Xor(True, And(y, z), And(x, y, z), remove_true=False)

gxyd · 2017-12-28T16:51:59Z

sympy/logic/boolalg.py

for this as well is missing.

This was refactored as

def to_anf(self, deep=True): args = range(1, len(self.args) + 1) args = (combinations(self.args, j) for j in args) args = chain.from_iterable(args) # powerset args = (And(*arg) for arg in args) args = map(lambda x: to_anf(x, deep=deep) if deep else x, args) return Xor(*list(args), remove_true=False)

And covered with tests

assert to_anf(Or(x, y)) == Xor(x, y, And(x, y)) assert to_anf(Or(Implies(x, y), And(x, y), y)) == \ Xor(x, True, x & y, remove_true=False) assert to_anf(Or(Nand(x, y), Nor(x, y), Xnor(x, y), Implies(x, y))) == True assert to_anf(Or(x, Not(y), Nor(x,z), And(x, y), Nand(y, z))) == \ Xor(True, And(y, z), And(x, y, z), remove_true=False)

czgdp1807 · 2019-09-21T07:32:39Z

@asmeurer Please provide updates on this PR?

czgdp1807 · 2019-09-21T07:33:09Z

@konstantintogoi Please resolve conflicts in this PR, if you are still interested to work on this.

Added new features for converting boolean expression to Algebraic Normal Form. New functions: - to_anf - is_anf - distribute_xor_over_and - _convert_to_varsANF - anf_coeffs - ANFform - minterm - maxterm - monomial New instance method 'to_anf' and new class method '_to_anf'

sympy-bot · 2020-02-05T00:06:17Z

✅

Hi, I am the SymPy bot (v150). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

logic
- Added a new normal form - ANFform. Function ANFform converts a list of truth values to an expression in Algebraic Normal Form (ANF). (#13686 by @KonstantinTogoi)
- Added a new method BooleanFunction.to_anf that converts an expression to ANF by equivalent transformations. (#13686 by @KonstantinTogoi)
- Added a new function is_anf that checks if an expression is ANF. (#13686 by @KonstantinTogoi)
- Added a new function to_anf that converts an expression to ANF if it is not ANF. (#13686 by @KonstantinTogoi)
- Added a new function distribute_xor_over_and. Given a sentence s consisting of conjunction and exclusive disjunctions of literals, it returns an equivalent exclusive disjunction. (#13686 by @KonstantinTogoi)
- Added a new function bool_minterm that returns the k-th minterm of a fixed ordered set of binary variables. (#13686 by @KonstantinTogoi)
- Added a new function bool_maxterm that returns the k-th maxterm of a fixed ordered set of binary variables. (#13686 by @KonstantinTogoi)
- Added a new function bool_monomial that returns the k-th monomial of a fixed ordered set of binary variables. (#13686 by @KonstantinTogoi)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- BEGIN RELEASE NOTES -->
* logic
  * Added a new normal form - `ANFform`. Function `ANFform` converts a list of truth values to an expression in Algebraic Normal Form (ANF).
  * Added a new method `BooleanFunction.to_anf` that converts an expression to ANF by equivalent transformations.
  * Added a new function `is_anf` that checks if an expression is ANF.
  * Added a new function `to_anf` that converts an expression to ANF if it is not ANF.
  * Added a new function `distribute_xor_over_and`. Given a sentence `s` consisting of conjunction and exclusive disjunctions of literals, it returns an equivalent exclusive disjunction.
  * Added a new function `bool_minterm` that returns the k-th minterm of a fixed ordered set of binary variables.
  * Added a new function `bool_maxterm` that returns the k-th maxterm of a fixed ordered set of binary variables.
  * Added a new function `bool_monomial` that returns the k-th monomial of a fixed ordered set of binary variables.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

codecov · 2020-02-05T02:39:13Z

Codecov Report

Merging #13686 into master will increase coverage by 0.052%.
The diff coverage is 91.15%.

@@              Coverage Diff              @@
##            master    #13686       +/-   ##
=============================================
+ Coverage   75.545%   75.598%   +0.052%     
=============================================
  Files          642       644        +2     
  Lines       167277    167812      +535     
  Branches     39441     39561      +120     
=============================================
+ Hits        126371    126864      +493     
- Misses       35382     35409       +27     
- Partials      5524      5539       +15

konstantintogoi · 2020-02-10T09:16:48Z

I think you have mistakenly changed the mode of sympy/logic/boolalg.py from 100644 -> 100755. Please remove that.

Fixed.

konstantintogoi · 2020-02-10T09:17:11Z

Also for the test file, seems like you made it executable.

Fixed.

konstantintogoi · 2020-02-10T09:18:51Z

@konstantintogoi Please resolve conflicts in this PR, if you are still interested to work on this.

Done.

sylee957 · 2020-02-17T03:41:16Z

sympy/logic/boolalg.py

+    return _convert_to_varsPOS(k, variables)
+
+
+def monomial(k, variables):


monomial can be too much a common word that can be used by other disciplines.
https://en.wikipedia.org/wiki/Monomial
So I would have a suggestion to name this more specific. like prefixing bool_monimial, bool_minterm, bool_maxterm

I've renamed the functions

asmeurer reviewed Dec 7, 2017

View reviewed changes

sympy/logic/boolalg.py Outdated Show resolved Hide resolved

sympy/logic/boolalg.py Outdated Show resolved Hide resolved

sympy/logic/boolalg.py Show resolved Hide resolved

gxyd reviewed Dec 7, 2017

View reviewed changes

gxyd reviewed Dec 28, 2017

View reviewed changes

gxyd added the PR: author's turn The PR has been reviewed and the author needs to submit more changes. label Jan 21, 2018

Abdullahjavednesar added PR: sympy's turn and removed PR: author's turn The PR has been reviewed and the author needs to submit more changes. labels Apr 17, 2018

oscarbenjamin added the logic label Feb 1, 2019

czgdp1807 added Please take over and removed PR: sympy's turn labels Nov 19, 2019

konstantintogoi added 3 commits February 5, 2020 03:03

edit docstrings

18b208b

fix Or.to_anf()

9b2d3ab

update old-fashioned output in docstrings

b7fd728

add some math rendering and newlines

3d904cf

sylee957 reviewed Feb 17, 2020

View reviewed changes

Add prefix 'bool_' to minterm, maxterm, monomial

f8c83fd

sylee957 merged commit e3a95d9 into sympy:master Feb 18, 2020

sylee957 mentioned this pull request Oct 15, 2020

Converting Boolean formulas to Boolean polynomials (Zhegalkin polynomials) #20262

Open

		return _convert_to_varsPOS(k, variables)


		def monomial(k, variables):

Uh oh!

Logic: algebraic normal form (Zhegalkin polynomial) #13686

Logic: algebraic normal form (Zhegalkin polynomial) #13686

Uh oh!

Conversation

konstantintogoi commented Dec 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gxyd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gxyd commented Dec 7, 2017 via email

Uh oh!

gxyd commented Dec 28, 2017

Uh oh!

gxyd commented Dec 28, 2017

Uh oh!

gxyd Dec 28, 2017

Choose a reason for hiding this comment

Uh oh!

konstantintogoi Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

gxyd Dec 28, 2017

Choose a reason for hiding this comment

Uh oh!

konstantintogoi Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

czgdp1807 commented Sep 21, 2019

Uh oh!

czgdp1807 commented Sep 21, 2019

Uh oh!

sympy-bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

konstantintogoi commented Feb 10, 2020

Uh oh!

konstantintogoi commented Feb 10, 2020

Uh oh!

konstantintogoi commented Feb 10, 2020

Uh oh!

sylee957 Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

konstantintogoi Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

konstantintogoi commented Dec 7, 2017 •

edited

Loading

sympy-bot commented Feb 5, 2020 •

edited

Loading

codecov bot commented Feb 5, 2020 •

edited

Loading