Prefer sass over node-sass #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I faced one issue which is related to vue-loader, if you use scoped styles and still want to style a deeper element, you can use |
|
yeah, that's because the |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 5, 2020
This PR was submitted for the 5.2 branch but it was merged into the 4.4 branch instead. Discussion ---------- Prefer sass over node-sass Hi! `node-sass` is deprecated in favor of `sass` - https://sass-lang.com/blog/libsass-is-deprecated. Encore works exactly the same with both, and `sass` doesn't require an annoying compile step that sometimes fails anyways. And also, here is the PR that will change which library is recommended: symfony/webpack-encore#870 I will merge and tag that shortly. Commits ------- 41418b7 Prefer sass over node-sass
pfz
pushed a commit
to pfz/webpack-encore
that referenced
this pull request
Dec 14, 2020
This PR was merged into the main branch. Discussion ---------- Prefer sass over node-sass This will change the recommendation to `sass` instead of `node-sass` which is deprecated and harder to deal with. I haven't had any issues or differences working with `sass` yet vs `node-sass`. I also upgraded the lock file in general, it makes it easier to see what packages are legitimately out of date and doesn't affect end users. Commits ------- aec475d prefer sass over node-sass
pfz
pushed a commit
to pfz/webpack-encore
that referenced
this pull request
Dec 14, 2020
This PR was merged into the main branch. Discussion ---------- Prefer sass over node-sass This will change the recommendation to `sass` instead of `node-sass` which is deprecated and harder to deal with. I haven't had any issues or differences working with `sass` yet vs `node-sass`. I also upgraded the lock file in general, it makes it easier to see what packages are legitimately out of date and doesn't affect end users. Commits ------- aec475d prefer sass over node-sass
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change the recommendation to
sassinstead ofnode-sasswhich is deprecated and harder to deal with. I haven't had any issues or differences working withsassyet vsnode-sass.I also upgraded the lock file in general, it makes it easier to see what packages are legitimately out of date and doesn't affect end users.