Allow usage of devServer combined with an absolute URL as publicPath #66
Conversation
when using dev-server and an absolute URL for publicPath to get webpack encore working in docker environment
test for successful config set when using devServer and setPublicPath with an absolute URL
- when using devServer and absolute URL for publicPath - also add test case
robertfausk
changed the title
|
Yes! Thanks for the PR! +1 for how you've done the warning. It's quite likely we'll need to refactor into more of a "logging" system... but that can be done easily later. I think we should add a new flag to activate this behavior - e.g. With this new flag, if I have I think it'll also simplify things - we won't need a warning anymore: we'll throw an exception like now... unless they have the new Wdyt? |
update to symfony/webpack-encore
|
I'm working on this locally - I've incorporated your commits. So, I'll close this and make a new PR soon :) |
…ausk, weaverryan) This PR was merged into the master branch. Discussion ---------- Relaxed public path requirements with dev-server Fixes #59 and finishes #66. * Adds a new `--keep-public-path` option for `dev-server`. When used, your `publicPath` is not prefixed with the dev server URL. For #59, this means you can use `setPublicPath('/build')` with the dev-server, and your assets will remain local (i.e. `/build/main.js` instead of `http://localhost:8080/build/main.js`). * It is now possible to pass an absolute URL to `setPublicPath()` without an error when using `dev-server`. But, we issue a big warning, because this means your assets will point to to that absolute URL, instead of to the dev-server (which for most setups, is not what you want). @samjarrett I'd love to confirm that this would solve your issue in Docker :). Commits ------- 4bc1e19 Using real public path, though it doesn't look like it matters 92e22af Allowing an absolute publicPath with dev-server, but showing a warning 830fdb5 Adding --keep-public-path to dev-server to allow you to fully control the publicPath b27f7c9 Reversing some of the changes we won't do for now, and adding the failing test e206a12 fix issue in generated public path of manifest.json eb5565b convert error into warning 910b6bc convert error into warning
This fixes #59 when webpack encore is used inside a docker container and webpack-dev-server needs an absolute URL.
I'm not sure about printing and message of warning.
I used console.log for printing analogous to "bin/encore.js" but maybe FriendlyErrorsWebpackPlugin should be used... There aren't any other warnings yet whjch I could take for reference.