[TypeScript] Improve public API configuration option types - #1521
Merged
Kocal merged 1 commit intoJul 23, 2026
Merged
Conversation
Retype the configuration methods that used a bare `object`. Options now resolve to the real loader/plugin types: reused via inline `import()` where the package ships them (friendly-errors, manifest, dev-server, babel presets, fork-ts-checker, vue-loader, webpack-notifier, ts-loader, split-chunks), and hand-written interfaces aligned with the supported peerDependency ranges for the loaders that ship no usable types (css/style/sass/less/stylus/postcss/handlebars-loader).
Kocal
marked this pull request as ready for review
July 22, 2026 05:15
Kocal
added a commit
that referenced
this pull request
Jul 23, 2026
Kocal
added a commit
that referenced
this pull request
Jul 23, 2026
This PR was squashed before being merged into the main branch. Discussion ---------- Migrate project to TypeScript ✨ | Q | A | -------------- | --- | Bug fix? | no | New feature? | yes <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #816 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> Commits ------- 53a691a [TypeScript] Improve public API configuration option types (#1521) bbebcee Minor improvements c1e0ecc [TypeScript] Use .js import specifiers and drop TS-extension tsconfig options (#1512) 283f574 [TypeScript] Migrate `index.js` (#1511) 4715f6e [TypeScript] Migrate `lib/*` (#1510) aabcc9e [TypeScript] Migrate `lib/webpack/*` (#1509) 91ee952 [TypeScript] Migrate `lib/config/*` (#1508) 26451d4 [TypeScript] Improve "too weak" types 2077a7c [TypeScript] Migrate `lib/plugins/*` (#1507) 5546c1a [TypeScript] Migrate `lib/loaders/*` (#1506) e14a18f [TypeScript] Migrate `lib/plugins/*` (#1505) 21db592 [TypeScript] Migrate `lib/utils/*` (#1504) 3e3c786 Prepare TypeScript migration (#1502)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retype the configuration methods that used a bare
object.Options now resolve to the real loader/plugin types:
import()where the package ships them (friendly-errors,manifest,dev-server,babelpresets,fork-ts-checker,vue-loader,webpack-notifier,ts-loader,split-chunks),css/style/sass/less/stylus/postcss/handlebars-loader).