Add some types in the internal implementation of Encore #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with type-checking the codebase
stof
commented
Sep 5, 2024
| const cache = {}; | ||
|
|
||
| cache.type = 'filesystem'; | ||
| cache.type = /** @type {const} */ ('filesystem'); |
Member
Author
There was a problem hiding this comment.
this syntax with /** @type */ followed by a parenthesized expression as the JSDoc syntax for a cast.
Using const as type allows to do the same than as const in typescript
Kocal
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow type-checking the codebase, by fixing cases where the typescript inference is not sufficient without a hint.