Loader features refactor #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidmpaz can you rebase now? I broke this with your other PR ;) #101 |
|
I will, once I get in front of a pc again at home.
Am 05.08.2017 14:11 schrieb "Ryan Weaver" <notifications@github.com>:
… @davidmpaz <https://github.com/davidmpaz> can you rebase now? I broke
this with your other PR ;) #101
<#101>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM3NmRvLfTG4ZbPfoUfbBh2VVnxJpQpks5sVFwDgaJpZM4OpWRb>
.
|
Make naming more general since it can be used for plugins as well.
Remove reference to loader. Module will be used in more general scope.
Missing plugins errors are not captured by webpack, but in node loading process. Plugins require is delayed untill check for packages is done in `ensurePackagesExist`. At this time proper error is raised.
|
Awesome, thank you David! |
weaverryan
added a commit
that referenced
this pull request
Aug 10, 2017
This PR was squashed before being merged into the master branch (closes #123). Discussion ---------- Loader features refactor These are internal changes to match current usage of `loader-features.js`, renaming mostly. Package checker is not used uniquely for loaders, but also node modules in general, like plugins. Commits ------- b7eff23 Loader features refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are internal changes to match current usage of
loader-features.js, renaming mostly. Package checker is not used uniquely for loaders, but also node modules in general, like plugins.