Skip to content

Support AVIF images #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Support AVIF images #1056

wants to merge 3 commits into from

Conversation

@benbankes
Copy link
Contributor

@benbankes benbankes commented Oct 28, 2021

No description provided.

@benbankes
Copy link
Contributor Author

benbankes commented Oct 29, 2021

It doesn't feel like these test failures are a result of my change. I am using this change successfully with avif images.

@weaverryan weaverryan mentioned this pull request Jan 21, 2022
Merged
@weaverryan
Copy link
Member

weaverryan commented Jan 21, 2022

Sorry for the delay! My guess is also that the test failures were unrelated, and have quite possibly been fixed upstream since then (main is green right now). I've just rebased your work onto #1074.

Cheers!

@weaverryan weaverryan closed this Jan 21, 2022
weaverryan added a commit that referenced this pull request Jan 21, 2022
@weaverryan
feature #1074 Rebase of avif support (benbankes, weaverryan)
ed21815 
This PR was merged into the main branch.

Discussion
----------

Rebase of avif support

Just a rebase of #1056 - probably the failures there were temporary to when that PR was opened.

Commits
-------

1f6874e updating tests
abd66f4 Also modify the test images rule
2d0c725 Support AVIF images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benbankes @weaverryan