Support babel option includeNodeModules with pnpm

[leonexcc]

The option includeNodeModules of bable doesn't work with pnpm, since filePath will contain the real path after resolving the link (for example .../node_modules/.pnpm/plyr@3.6.2/node_modules/plyr/...)

After replacing

const whitelistedModules = options[optionKey].map(
     module => path.join('node_modules', module) + path.sep
);

with

const whitelistedModules = options[optionKey].map(
    module => path.dirname(require.resolve(module + '/package.json'))
);

it works as expected.

Also the mapping is currently executed for each file again. This could probably done once outside of the callback.

[stof]

Doing require.resolve when processing the config will have several issues:

• it restricts that to packages that can be resolved from the root, while the current approach works for any transitive deps too
• it won't work for packages using the new exports config (available in Node 13+), as package.json might not be an allowed export of the package

also, I don't think the path .../node_modules/.pnpm/plyr@3.6.2/node_modules/plyr/... is an issue. This path has node_modules/plyr/ in it.

[leonexcc]

You are right. My issue was that my modules in includeNodeModules were not transpiled and i thought this was the reason. But i used a .babelrc instead of a babel.config.json and the .babelrc is ignored for node modules. Maybe this could be documented somewhere next to the includeNodeModules option.

[stof]

Documenting that makes sense.
Or maybe even detecting this case automatically in Encore. Is this possible @weaverryan @Lyrkan ?

[Lyrkan]

Or maybe even detecting this case automatically in Encore. Is this possible @weaverryan @Lyrkan ?

I think we could... we currently check for both files (and package.json config) here:

webpack-encore/lib/config/parse-runtime.js

Lines 88 to 104 in a7d76ee

	const partialConfig = babel.loadPartialConfig({
	/*
	* There are two types of babel configuration:
	* - project-wide configuration in babel.config.* files
	* - file-relative configuration in .babelrc.* files
	* or package.json files with a "babel" key
	*
	* To detect the file-relative configuration we need
	* to set the following values. The filename is needed
	* for Babel as an example so that it knows where it
	* needs to search the relative config for.
	*/
	root: cwd,
	cwd: cwd,
	filename: path.join(cwd, 'webpack.config.js')
	});
	runtimeConfig.babelRcFileExists = partialConfig.hasFilesystemConfig();

But before #738 we only had a check for the existence of .babelrc files using:

runtimeConfig.babelRcFileExists = (typeof partialConfig.babelrc === 'string');

Maybe we could have both of them instead (that will require to refactor some other files to use babelConfigExists instead of babelRcFileExists):

runtimeConfig.babelConfigExists = partialConfig.hasFilesystemConfig();
runtimeConfig.babelRcFileExists = partialConfig.babelrc !== undefined; // Slightly changed the old check to match https://github.com/babel/babel/blob/af669297efd775016725ee39318cdb391cf00a21/packages/babel-core/src/config/partial.js#L199

And then trigger a warning if configureBabel() is called with the includeNodeModules option when there is a .babelrc file (runtimeConfig.babelRcFileExists) without any global config (!runtimeConfig.babelConfigExists) ?

[stof]

This suggestion looks good to me