bump to php >=8.1 everywhere #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jun 15, 2023
bendavies
force-pushed
the
php-8.1
branch
28 times, most recently
from
89a06e3 to
5b0cce6
Compare
bendavies
force-pushed
the
php-8.1
branch
8 times, most recently
from
7b61f23 to
f643861
Compare
|
@weaverryan this is ready for review. |
|
php-cs-fixer is failing because v3.18 was released, i think |
weaverryan
reviewed
Jun 19, 2023
weaverryan
reviewed
Jun 19, 2023
bendavies
force-pushed
the
php-8.1
branch
3 times, most recently
from
6fb49a3 to
b15796b
Compare
|
Thank you Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions of php were a bit disparate. they should be the same everywhere.
workflows for for 7.2 and 8.0 removed.
testing for php 8.2 should probably be added