Skip to content

fix(translator): generate unique constants name (fix #938) #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jun 15, 2023

Q A
Bug fix? yes
New feature? no
Tickets Fix #938
License MIT

Generating constants name with a automatic-prefix, in order to prevent conflicts when they are dumped in JS.

@weaverryan
Copy link
Member

Thanks Hugo!

@weaverryan weaverryan merged commit 7fe7ee2 into symfony:2.x Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translator] TranslationsDumper generates duplicate keys in JS translation files
2 participants