[LiveComponent] Working around issue where FormView is passed to the component #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
fix-live-component-form-compound
branch
from
1dbe927 to
67bc0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, the FormView will likely be initialized with certain data and, in the case of something like a CollectionType, it will have certain children fields. If we try to get the "form instance", that will be created "fresh" with different data and different fields, which causes the "compound" check to fail.
Getting the "compound" from the form instance was always a workaround for autocomplete, which tricks us by changing their compound flag. This goes back to the original logic, with a workaround for autocomplete.
Cheers!