Skip to content

[Live] Removing docs showing the proxied component #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? yes
New feature? no
Tickets None
License MIT

3 small things:

  1. The docs were wrong - calling this.component.set() does not, on its own, trigger a re-render. this.component.render() is also needed.
  2. When using getComponent(), the Proxy wrapped object is not returned, so doing things like this.someModel = 'bar' does not work. And I think we shouldn't make it work - the Proxy is just some unnecessary magic and it would add complexity to introduce it here.
  3. The interval was never cleared - minor, but we were running the interval a few extra times after returning times.

Cheers!

@weaverryan weaverryan force-pushed the live-model-set-fix branch from d3d809a to ccd4e5d Compare June 6, 2023 14:50
@weaverryan weaverryan merged commit 6b20ca7 into symfony:2.x Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant