Fix empty collections error on demo app #862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @luchidalgo! Thanks for this! But I think I beat you to it by just 1 day (which is crazy because this is an old bug!) #857 Let me know if you have any issues or disagreements with that fix. And actually, it's been tweaked a bit more at #866 Cheers and thanks! |
|
Excellent😃👍 Thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix the "empty collection" error on demo app https://ux.symfony.com/live-component/demos/form-collection-type (juste remove the last element of collection and error appear because empty collection don't fallback in condition ComponentWithFormTrait.php:238)