-
-
Notifications
You must be signed in to change notification settings - Fork 357
Enabling files upload #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2d13c27
Allow files to be passed to `RequestBuilder` and move request body un…
Lustmored 14a640b
Make files mandatory in Backend.ts and pass empty map from controller
Lustmored b5ff362
Add tests for passing files to RequestBuilder and make them pass
Lustmored fe69154
Read POST payload from `data` key instead of a request body
Lustmored 7fd6e5a
Rebuild assets
Lustmored 458ba60
Add possibility to send files with an action
Lustmored ad70f81
Hook up files in Component and build assets
Lustmored 7ea3fbb
Add extremely simple upload files example
Lustmored 610b216
Add very simple upload files docs
Lustmored cf8ef71
Code style
Lustmored c7c56f0
Use `expectException` to mitigate test failures.
Lustmored c74f689
Rebuild dist assets
Lustmored 2155865
Stop using data-model on file inputs as an alternative. It's pointless
Lustmored 0e1013e
Pump up docs
Lustmored 1f74e6d
Clear pendingFiles after being sent
Lustmored 65e2794
Rewire files handling to actually send files only once and clear inpu…
Lustmored 1a147a2
Adapt tests again
Lustmored cc41980
[Upload] Updating demo
weaverryan 380b492
phpcs
weaverryan d29df00
Fixing test
weaverryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could just be?
const totalFiles = Object.keys(files).length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not - that would count
FileList
objects passed, but they can be empty (like inputs with no files selected). In that case we should not count them.Actually maybe what would be more fitting is to first filter
files
to remove emptyFileList
s and then just use what you propose.