Skip to content

Add docs for the new Twig Component syntax #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2023
Merged

Add docs for the new Twig Component syntax #792

merged 1 commit into from
Apr 16, 2023

Conversation

WebMamba
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Tickets
License MIT

see #771

weaverryan
weaverryan reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome start!

@WebMamba
Copy link
Contributor Author

@weaverryan I resolved your comments! And I add a small paragraph for the embedded component 😁

weaverryan
weaverryan reviewed Apr 16, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more notes - looking nice 👍

@weaverryan
Copy link
Member

Thanks Matheo!

@weaverryan weaverryan merged commit 1620116 into symfony:2.x Apr 16, 2023
@weaverryan weaverryan mentioned this pull request Apr 16, 2023
Merged
norkunas
norkunas reviewed Apr 17, 2023
View reviewed changes
src/TwigComponent/doc/index.rst
.. code-block:: html+twig

// "withActions" property will be set to true
<twig:Alert withActions message="hello"></:Alert>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong closing?

norkunas
norkunas reviewed Apr 17, 2023
View reviewed changes
src/TwigComponent/doc/index.rst
<div class="content">
{% block footer %}
...
{% block footer %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be endblock?

norkunas
norkunas reviewed Apr 17, 2023
View reviewed changes
src/TwigComponent/doc/index.rst
{% endblock %}
{% block footer %}
...
{% block footer %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be endblock?

@weaverryan
Copy link
Member

@norkunas there were a few bugs - I hopefully fixed them all in #799

weaverryan added a commit that referenced this pull request Apr 18, 2023
@weaverryan
minor #799 [Twig] Tweaking docs for new HTML syntax (weaverryan)
a51d9c9 
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[Twig] Tweaking docs for new HTML syntax

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Tickets       | None
| License       | MIT

Just following up with a few more tweaks to `@WebMamba`'s docs in #792.

Cheers!

Commits
-------

6691401 [Twig] Tweaking docs for new HTML syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

@norkunas norkunas norkunas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WebMamba @weaverryan @norkunas