[Live] coerce falsey strings to scalar types #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Nov 7, 2022
| @@ -148,6 +148,8 @@ public function hydrate(object $component, array $data, string $componentName): | |||
| if ($method = $liveProp->hydrateMethod()) { | |||
| // TODO: Error checking | |||
| $value = $component->$method($value); | |||
| } elseif (\is_string($value) && $type && \in_array($type->getName(), ['int', 'float', 'bool'], true)) { | |||
| $value = self::coerceScalarValue($value, $type); | |||
| } elseif (!$value && $type && $type->allowsNull() && is_a($type->getName(), \BackedEnum::class, true) && !\in_array($value, array_map(fn (\BackedEnum $e) => $e->value, $type->getName()::cases()))) { | |||
| $value = null; | |||
| } elseif (null !== $value && $type && !$type->isBuiltin()) { | |||
There was a problem hiding this comment.
This area is increasingly feeling "ad-hoc", but it's well-covered in tests. And if there is some broader solution for handling these edge cases, it'll become obvious eventually 👍
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose to allow weird values to be cast to the proper type instead of throwing an exception (ie
0 === (int) 'apple').