[Autocomplete] add option to specify minimum characters for autocomplete #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daFish
force-pushed
the
feat/gh-432-autocomplete-minimum-characters
branch
from
3b76cae to
adc5176
Compare
daFish
changed the title
weaverryan
reviewed
Oct 7, 2022
daFish
force-pushed
the
feat/gh-432-autocomplete-minimum-characters
branch
from
adc5176 to
e3b6905
Compare
|
@weaverryan Should all be fine now and all checks are happy. |
daFish
force-pushed
the
feat/gh-432-autocomplete-minimum-characters
branch
from
e3b6905 to
4c55dcb
Compare
weaverryan
force-pushed
the
feat/gh-432-autocomplete-minimum-characters
branch
from
4c55dcb to
604ad69
Compare
|
Thank you Marcus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new option
min_charactersfor specifying the value of entered characters before the autocomplete is triggerd. This avoids calls with an empty query.Todos:
@weaverryan I also added a
CHANGELOG.mdbecause this file wasn't present.