Repository navigation
[Notify] Add support for MercureBundle ^0.6 - #4056
Merged
Merged
Conversation
carsonbot
added
Documentation
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||
Kocal
force-pushed
the
claude/mercurebundle-0-6-support-bbeb01
branch
from
October 8, 2026 14:43
ba4c6af to
ddba479
Compare
Kocal
changed the title
| Q | A | -------------- | --- | Bug fix? | no | New feature? | yes | Deprecations? | no | Documentation? | yes | Issues | | License | MIT MercureBundle 0.6 makes the Mercure protocol 1.0 the default, and a protocol 1.0 subscriber passes its topics in the `match` query parameter instead of `topic`. The Notify Stimulus controller only knew `topic`, so on a hub left on that default it subscribed to nothing. `stream_notifications()` now renders the hub's protocol as a Stimulus controller value, and the controller builds its `EventSource` URLs with `match` on the protocol 1.0. A hub on the protocol 0.x renders no such value and keeps `topic`, so existing markup is unaffected. The two test apps now pin `protocol_version: 0.x`, which is what their hub actually speaks.
Kocal
force-pushed
the
claude/mercurebundle-0-6-support-bbeb01
branch
from
October 8, 2026 15:12
ddba479 to
8dc87e6
Compare
kbond
approved these changes
Oct 9, 2026
carsonbot
added
Status: Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MercureBundle 0.6 makes the Mercure protocol 1.0 the default, and a protocol 1.0 subscriber passes its topics in the
matchquery parameter instead oftopic. The Notify Stimulus controller only knewtopic, so on a hub left on that default it subscribed to nothing.stream_notifications()now renders the hub's protocol as a Stimulus controller value, and the controller builds itsEventSourceURLs withmatchon the protocol 1.0. A hub on the protocol 0.x renders no such value and keepstopic, so existing markup is unaffected.The two test apps now pin
protocol_version: 0.x, which is what their hub actually speaks.