Repository navigation
[Toolkit] Fix the drawer snapshots broken by twig-tailwind-extra 1.5.0 - #4042
Merged
Kocal merged 1 commit intoOct 5, 2026
Merged
Conversation
| Q | A | -------------- | --- | Bug fix? | no | New feature? | no | Deprecations? | no | Documentation? | no | Issues | | License | MIT `tales-from-a-dev/twig-tailwind-extra` 1.5.0 (released 2026-10-04) changed how `|tailwind_classes` resolves conflicting utilities: it now drops `max-h-none` when `max-h-[80vh]` comes after it, which broke the 3 rendering snapshots of the `shadcn/drawer` recipe and failed every PHP CI job. I regenerated the snapshots; the drawer screenshots themselves didn't change, only the class list in the rendered HTML. While regenerating them, `bin/update_toolkit_tests.sh` failed with `jq: parse error: Invalid numeric literal`. The cause: when `pnpm-lock.yaml` has changed (for example after a pull), pnpm 11 checks dependencies before running `pnpm exec` and prints its install report on stdout ahead of Playwright's JSON output, so `jq` ends up trying to parse pnpm's report instead. The script now has Playwright's JSON reporter write to a temporary file via `PLAYWRIGHT_JSON_OUTPUT_FILE`, and `jq` reads that file instead of stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tales-from-a-dev/twig-tailwind-extra1.5.0 (released 2026-10-04) changed how|tailwind_classesresolves conflicting utilities: it now dropsmax-h-nonewhenmax-h-[80vh]comes after it, which broke the 3 rendering snapshots of theshadcn/drawerrecipe and failed every PHP CI job. I regenerated the snapshots; the drawer screenshots themselves didn't change, only the class list in the rendered HTML.While regenerating them,
bin/update_toolkit_tests.shfailed withjq: parse error: Invalid numeric literal. The cause: whenpnpm-lock.yamlhas changed (for example after a pull), pnpm 11 checks dependencies before runningpnpm execand prints its install report on stdout ahead of Playwright's JSON output, sojqends up trying to parse pnpm's report instead. The script now has Playwright's JSON reporter write to a temporary file viaPLAYWRIGHT_JSON_OUTPUT_FILE, andjqreads that file instead of stdout.