[TwigComponent] Document high-order components #3330
Merged
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kocal
commented
Feb 2, 2026
Kocal
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Documentation? | yes |
| Issues | Fix #3329 |
| License | MIT |
carsonbot
added
Bug
There was a problem hiding this comment.
Pull request overview
This PR documents the higher-order components (component wrappers) feature in TwigComponent, which allows creating component variants that wrap other components while adding default attributes.
Changes:
- Added documentation section explaining higher-order components with code examples
- Added comprehensive test coverage for higher-order component functionality
- Created test fixtures demonstrating button component wrapping patterns
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/TwigComponent/doc/index.rst | Added documentation section with examples of creating and using higher-order components |
| src/TwigComponent/tests/Integration/ComponentExtensionTest.php | Added test method verifying attribute merging behavior in higher-order components |
| src/TwigComponent/tests/Fixtures/templates/higher_order_component.html.twig | Created test template demonstrating various higher-order component usage patterns |
| src/TwigComponent/tests/Fixtures/templates/components/SimpleButton/Primary.html.twig | Created Primary button variant component that wraps SimpleButton |
| src/TwigComponent/tests/Fixtures/templates/components/SimpleButton.html.twig | Created base SimpleButton component with default attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.