Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Jan 3, 2026

Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? no
Issues Fix #...
License MIT

I'm not sure to understand why Fabbot Twig-CS-Fixer check is failing, but too much files are being linted:


 [OK] Files linted: 62, notices: 0, warnings: 0, errors: 0                      

Error: Twig-CS-Fixer found style issues. Please apply the patch below.

 
 git apply - <<'EOF_PATCH'
Only in b/: a
EOF_PATCH
 

Then commit the changes and push to your PR branch.

I'm not able to reproduce it locally

EDIT: I forgot to remove b directory 🤦🏻

@Kocal Kocal self-assigned this Jan 3, 2026
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jan 3, 2026
@carsonbot carsonbot changed the title Run Twig-CS-Fixer on all repo's files, follow #3263 Run Twig-CS-Fixer on all repo's files, follow #3263 Jan 3, 2026
Kocal added a commit to Kocal/symfony-fabbot that referenced this pull request Jan 3, 2026
Sorry, I should have been more careful.

It should fix the issue found in symfony/ux#3264
nicolas-grekas pushed a commit to symfony-tools/fabbot that referenced this pull request Jan 3, 2026
Sorry, I should have been more careful.

It should fix the issue found in symfony/ux#3264
@Kocal Kocal force-pushed the 3263-for-twig-cs-fixer branch from aeb82d9 to d5ae9b7 Compare January 3, 2026 22:41
@Kocal Kocal merged commit 7a2fb41 into symfony:2.x Jan 3, 2026
24 of 29 checks passed
Kocal added a commit to Kocal/symfony that referenced this pull request Jan 3, 2026
Kocal added a commit to Kocal/symfony that referenced this pull request Jan 4, 2026
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Jan 5, 2026
… necessary (Kocal)

This PR was merged into the 7.4 branch.

Discussion
----------

 Configure Twig-CS-Fixer to lint all files and exclude if necessary

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no <!-- if yes, also update src/**/CHANGELOG.md -->
| Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #"; no need to create an issue if none exists, explain below -->
| License       | MIT

Following internal discussions with `@nicolas`-grekas about https://github.com/symfony/symfony/actions/runs/20663092372/job/59329680460?pr=62920.
Related to symfony/ux#3264 as well.

Commits
-------

d63c12e Configure Twig-CS-Fixer to lint all files and exclude if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants