Skip to content

Conversation

@Crovitche-1623
Copy link
Contributor

@Crovitche-1623 Crovitche-1623 commented Sep 20, 2025

Q A
Bug fix? yes
New feature? no
Deprecations? no
Documentation? yes
Issues Fix #3092
License MIT

@Kocal

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Sep 20, 2025
@carsonbot carsonbot changed the title docs: fix composer config to avoid modifying package.json automatically docs: fix composer config to avoid modifying package.json automatically Sep 20, 2025
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you very much!

(nitpicking here.. but i would call this a --very impactful-- documentation fix, but not a bug)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 21, 2025
@smnandre smnandre added Documentation Improvements or additions to documentation and removed Bug Bug Fix labels Sep 21, 2025
@smnandre smnandre changed the title docs: fix composer config to avoid modifying package.json automatically [Docs] Fix composer config to avoid modifying package.json automatically Sep 21, 2025
@Kocal
Copy link
Member

Kocal commented Sep 21, 2025

Thank you @Crovitche-1623.

@Kocal Kocal merged commit a336938 into symfony:2.x Sep 21, 2025
9 checks passed
@nicolas-grekas
Copy link
Member

--jsonflag is missing, or has this been fixed?

@Kocal
Copy link
Member

Kocal commented Oct 15, 2025

Yes it's still missing

Kocal added a commit that referenced this pull request Oct 16, 2025
This PR was merged into the 2.x branch.

Discussion
----------

 Add --json flag to composer config command

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | yes <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Follows #3091 and symfony/flex#1064

Commits
-------

92f37a9 Add --json flag to composer config command
@Kocal
Copy link
Member

Kocal commented Oct 16, 2025

Done in #3139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: The composer config does not work as expected

5 participants