[LiveComponent] Fix #[LiveProp(writable: true, url: true)] that was not updated as a query parameter

[mbuliard]

Q	A
Bug fix?	yes
New feature?	no
Docs?	no
Issues	Fix #2960 Fix #2975
License	MIT

Hi,
The LiveUrl feature in 2.28 introduced a few bugs and I would like to fix some :

• The symfony matcher uses the current method to find the route. The UrlFactory must temporarily replace it by a GET. Will fix the MethodNotAllowedException bug of [LiveComponent] 500 errors with MethodNotAllowedException on dev after 2.28 upgrade #2960 Upgrade to 2.28 breaks live-props as url #2975
• The symfony matcher should not be given the query, only the path.

[Kocal]

Thanks for working on this, that's much appreciated! :)

Is the modified test enough to cover issue #2975, or should we add a dedicated one?

Also please, can you update your PR's title to something more relevant? Thanks!

[mbuliard]

Thanks for working on this, that's much appreciated! :)

Is the modified test enough to cover issue #2975, or should we add a dedicated one?

Also please, can you update your PR's title to something more relevant? Thanks!

@Kocal
I would have prefered to help for the fixes sooner but I was on vacation, without computer. :-/

I edited the fixtures of functional tests to reproduce the bug. Previously the route was accepting all methods and the problem was not detected.

I am confident that the issue #2975 is the same as the previous #2960 but the exception is caught by the hotfix #2961 and no new url is returned.

[Kocal]

So should we remove the MethodNotAllowedException from catch()?

[mbuliard]

So should we remove the MethodNotAllowedException from catch()?

I think the exception should not happen, but since the $previousUrl comes from user-land, anything can enter, including a url matching a POST route, which would throw the exception. I would keep catching it, just in case.

[Kocal]

I confirm it fixes #2975, thanks!

[Kocal]

Thank you @mbuliard.