Skip to content

[Map] Add Circle support #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

[Map] Add Circle support #2838

merged 1 commit into from
Jun 13, 2025

Conversation

Valmonzo
Copy link
Contributor

@Valmonzo Valmonzo commented Jun 13, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues
License MIT

Add Circle support for map (Googlemap and leaflet)

Capture d’écran 2025-06-13 à 14 02 13 Capture d’écran 2025-06-13 à 14 00 04

Kocal
Kocal reviewed Jun 13, 2025
View reviewed changes
@Valmonzo Valmonzo force-pushed the feat/add-circle-support-on-map branch from 9189aa7 to a9aebb0 Compare June 13, 2025 10:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map
abstract_map_controller.d.ts 4.97 kB / 1.16 kB 5.75 kB+16% 📈 / 1.25 kB+8% 📈
abstract_map_controller.js 3.99 kB / 1.07 kB 4.48 kB+12% 📈 / 1.14 kB+6% 📈
Map (Bridge Google)
map_controller.d.ts 2.73 kB / 828 B 3.03 kB+11% 📈 / 866 B+5% 📈
map_controller.js 11.18 kB / 2.53 kB 12.22 kB+9% 📈 / 2.65 kB+5% 📈
Map (Bridge Leaflet)
map_controller.d.ts 2.38 kB / 734 B 2.63 kB+10% 📈 / 781 B+6% 📈
map_controller.js 10.09 kB / 2.65 kB 11.06 kB+10% 📈 / 2.77 kB+4% 📈

@Valmonzo Valmonzo marked this pull request as ready for review June 13, 2025 12:03
@carsonbot carsonbot added Feature New Feature Map Status: Needs Review Needs to be reviewed labels Jun 13, 2025
Kocal
Kocal approved these changes Jun 13, 2025
View reviewed changes
src/Map/doc/index.rst
Comment on lines +211 to +212
Add Circles
~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I feel like we should start to link Google Maps/Leaflet documentation for markers, polygones, etc...

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 13, 2025
@Kocal Kocal changed the title [Map] add Circle support [Map] Add Circle support Jun 13, 2025
@Kocal Kocal force-pushed the feat/add-circle-support-on-map branch from 88f60dd to 0839a1d Compare June 13, 2025 21:13
@Kocal
Copy link
Member

Kocal commented Jun 13, 2025

Thank you @Valmonzo.

@Kocal Kocal merged commit 00e013e into symfony:2.x Jun 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Feature New Feature Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Valmonzo @Kocal @carsonbot