Skip to content

[LiveComponent] LiveProp: Pass the property name as second parameter of the modifier callback #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

[LiveComponent] LiveProp: Pass the property name as second parameter of the modifier callback #2744

merged 1 commit into from
May 23, 2025

Conversation

jannes-io
Copy link
Contributor

supersedes #2652

@jannes-io jannes-io mentioned this pull request May 16, 2025
Closed
smnandre
smnandre approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 16, 2025
Kocal
Kocal approved these changes May 16, 2025
View reviewed changes
@Kocal Kocal changed the title [LiveComponent] add property name to modifier function [LiveComponent] LiveProp: Pass the property name as second parameter of the modifier callback May 23, 2025
@Kocal Kocal force-pushed the modifier-propname branch from 2cfcbe5 to 8fb5245 Compare May 23, 2025 12:12
@Kocal Kocal added the Feature New Feature label May 23, 2025
@Kocal
Copy link
Member

Kocal commented May 23, 2025

Thank you @jannes-io.

@Kocal Kocal merged commit d815a1b into symfony:2.x May 23, 2025
16 of 17 checks passed
@jannes-io jannes-io deleted the modifier-propname branch May 23, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Feature New Feature LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jannes-io @Kocal @smnandre @carsonbot