Send data back and forth as JSON #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
reviewed
Feb 2, 2022
kbond
approved these changes
Feb 2, 2022
|
Also just want to point out that in this way it will be impossible to support #102 Bug I :) Unless with some workarounds which would allow to convert files to base64 so symfony serializer would transform it |
You're right that uploads will definitely NOT work after this. But I think it's still fixable - data uri is one approach, but we can also look into submitting a "multipart" request body (like a normal file upload) where one part is the file upload and another part is the JSON data. |
weaverryan
force-pushed
the
send-json-data
branch
from
20b8109 to
2b808ea
Compare
3 tasks
weaverryan
added a commit
that referenced
this pull request
Feb 4, 2022
…autofocus) (kbond) This PR was merged into the 2.x branch. Discussion ---------- [Twig][Live] null attribute values render without value (ie autofocus) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | n/a | License | MIT Ref: #220 (comment) A null attribute value renders without the _value_: ```twig {# templates/components/my_component.html.twig #} <input{{ attributes}}/> {# render component #} {{ component('my_component', { type: 'text', value: '', autofocus: null }) }} {# renders as: #} <input type="text" value="" autofocus/> ``` **TODO:** - [x] `null` vs `''` (#220 (comment)) - [x] attributes without a value like `autofocus` (#220 (comment)) - [x] LiveComponent dehydration/hydration issues (`null` values are lost during re-render) - solved in #264 Commits ------- c1e484b [Twig][Live] null attribute values render without value (ie autofocus)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr the "data" of your component is now sent via JSON for the Ajax calls. Ajax calls are still made via
GET(unless you're triggering an action or your data is too long) with a new?data={... json}.Longer Explanation
Until now, I've been trying to send data back to the server as
?queryparams or as POST data (which is just query params stored in the body of the request).However, using query parameters simply isn't robust enough. Most notably, it makes handling
nullvalues impossible. If you have a LiveProp - e.g.firstName- on the server set tonull, how should that be sent back to the server? As?firstName=? In that case, how do you distinguish from an empty string? One option is to NOT sendfirstNameat all on the Ajax request. But then, what if you have aLivePropthat is an array with['firstName' => null]? If we don't sendfirstName, the array will dehydrate to an empty array.In the end, the goal is to effectively "freeze" your component's data, send it to the frontend, and have the frontend send it back. Using query parameters simply isn't robust enough to do this without, but JSON is.
There is no real downside to this: it just felt more pure to send data back and forth as query parameters and return HTML. We still return HTML, but sending JSON will make the behavior solid.