-
-
Notifications
You must be signed in to change notification settings - Fork 361
[TwigComponent] Fix directory separator in Debug command #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@smnandre I've submitted the fix in this PR, but I haven’t included a test because I’m not quite sure how to mock or simulate |
Kocal
approved these changes
Nov 5, 2024
Thanks for your PR, I don't think you have something to do here, but ideally we should enable Windows builds on the CI |
smnandre
reviewed
Nov 5, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
reviewed
Nov 7, 2024
smnandre
approved these changes
Nov 7, 2024
Thanks @clussiana. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component template paths are retrieved by the
SplFileInfo
class, which returns paths containing backslashes on Windows and slashes on other operating systems.So on Windows environment, the command fails as the component
Card\Card.html.twig
is not formatted intoCard:Card