[Map] Fix custom attribute "data-controller" usage #2032
Merged
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
fix/map-render-attribute-data-controller
branch
from
5183989 to
708d8a6
Compare
Kocal
changed the title
|
Thanks for fixing this bug Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying the new UX Map component on my website, to migrate from my homemade solution, and it looks like I forgot to fully implement the
data-controllerspecial behavior.Calling
render_map(map, { 'data-controller': 'my-map' })will now correctly be rendered.