Skip to content

[Fix] Handle loading="lazy" for LiveComponent only #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2024
Merged

[Fix] Handle loading="lazy" for LiveComponent only #1976

merged 1 commit into from
Jul 12, 2024

Conversation

smnandre
Copy link
Member

Q A
Bug fix? yes
New feature? no
Issues Fix #1975
License MIT

A TwigComponent with loading=lazy was interpreted as a live and its attributes were changed.

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Jul 11, 2024
@smnandre smnandre requested a review from kbond July 11, 2024 16:59
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 11, 2024
@kbond
Copy link
Member

kbond commented Jul 12, 2024

Thanks Simon.

@kbond kbond merged commit bdd3107 into symfony:2.x Jul 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebMamba WebMamba WebMamba approved these changes

@kbond kbond Awaiting requested review from kbond

Assignees
No one assigned
Labels
Bug Bug Fix LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loading attribute without Live Component
4 participants
@smnandre @kbond @WebMamba @carsonbot