[Translator] Revert Fix changing dump directory using AssetMapper #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
Jun 12, 2024
Comment on lines
51
to
52
| $config['dump_directory'] => 'var/translations', // Keeping for BC, see https://github.com/symfony/ux/pull/1904#issuecomment-2162066941 | ||
| $config['dump_directory'] => '@app/translations', |
There was a problem hiding this comment.
You will only have 'var/translations' or '@app/translations' in the array, since the key is the same for both values
There was a problem hiding this comment.
You're right, when we tested it worked because we had it the other way around.
There's no way to fix this because even with
asset_mapper' => [
'paths' => [
__DIR__.'/../../assets/dist' => '@symfony/ux-translator',
$config['dump_directory'] => '@app/translations',
'%kernel.project_dir%/var/translations' => 'var/translations',
],
],the keys will be the same when running the default conf.
This reverts commit a27cfc8
maelanleborgne
force-pushed
the
feature/translator-allow-custom-dump-dir-asset-mapper
branch
from
4373448 to
e551cff
Compare
maelanleborgne
changed the title
smnandre
approved these changes
Jun 12, 2024
carsonbot
added
Status: Reviewed
|
Thank you @maelanleborgne. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced a bug : when using 'var/translations' in the
importmap.phpfile instead of a relative path, it would break the twigimportmap()function.This PR aims to rectify this regression by keeping a 'var/translations' namespace pointing to the dump_directory. If this is not accepted, the previous PR should be reverted to prevent users using 'var/translations' in thereimportmap.phpto face this issue, but the documentation should still be updated to display an example using the relative path instead of a misleading namespace.This PR reverts the change. A word in the doc to say that the
dump_directoryconf is not compatible with asset_mapper would be nice.