-
-
Notifications
You must be signed in to change notification settings - Fork 364
[Translator] Fix changing dump directory using AssetMapper #1904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,12 +43,12 @@ public function prepend(ContainerBuilder $container) | |
if (!$this->isAssetMapperAvailable($container)) { | ||
return; | ||
} | ||
|
||
$config = $container->getExtensionConfig('ux_translator')[0]; | ||
$container->prependExtensionConfig('framework', [ | ||
'asset_mapper' => [ | ||
'paths' => [ | ||
__DIR__.'/../../assets/dist' => '@symfony/ux-translator', | ||
'%kernel.project_dir%/var/translations' => 'var/translations', | ||
$config['dump_directory'] => '@app/translations', | ||
kbond marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add a functionnal test for this ? That will prevent any future regression There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how to test for this. I don't think I can access the config, and I can't functionally test this without requiring asset mapper in require-dev, which is not wanted. If you have any input on how I can retrieve the config from the test scope I'd be glad to hear about it :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I shouldn't have ignored this conversation 😭 |
||
], | ||
], | ||
]); | ||
|
Uh oh!
There was an error while loading. Please reload this page.