[Site] switch from highlight.js to tempest/highlight
#1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Apr 30, 2024
| color: #8b949e; | ||
| user-select: none; | ||
| -webkit-user-select: none | ||
| /** tempest/highlight theme (https://github.com/tempestphp/highlight/blob/main/src/Themes/Css/dracula.css) */ |
There was a problem hiding this comment.
@smnandre, perhaps you can create a follow-up PR to adjust the styles/theme (I may have broken some stuff (ie .codeblock-terminal .hljs-keyword).
BTW, I just randomly picked a dark theme here.
kbond
commented
Apr 30, 2024
| @@ -1,8 +1,8 @@ | |||
| {% props highlight = false, code = '', height = null %} | |||
| {% props code = '', height = null %} | |||
There was a problem hiding this comment.
I broke highlighting here and was unsure on how to fix.
@smnandre, what do you think about merging this component with CodeBlock to keep it simple? (again, followup PR)
kbond
force-pushed
the
site/tempest-highlight-2
branch
from
0c79bb9 to
22ef22e
Compare
smnandre
approved these changes
Apr 30, 2024
carsonbot
added
Status: Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1742. I now fully removed highlight.js.