[Site] refactor commonmark config

ux.symfony.com/config/services.yaml

@@ -23,9 +23,3 @@ services:
 
     # add more service definitions when explicit configuration is needed
     # please note that last definitions always *replace* previous ones
-
-    App\Service\CommonMark\CodeExtension:
-        tags: ['twig.markdown.league_extension']
-
-    League\CommonMark\Extension\ExternalLink\ExternalLinkExtension:
-        tags: ['twig.markdown.league_extension']

ux.symfony.com/src/Service/CommonMark/ConverterFactory.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Service\CommonMark;
+
+use League\CommonMark\CommonMarkConverter;
+use League\CommonMark\Extension\CommonMark\Node\Block\FencedCode;
+use League\CommonMark\Extension\ExternalLink\ExternalLinkExtension;
+use League\CommonMark\Extension\Mention\MentionExtension;
+use Symfony\Component\DependencyInjection\Attribute\AsDecorator;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+#[AsDecorator('twig.markdown.league_common_mark_converter_factory')]
+final class ConverterFactory
+{
+    public function __invoke(): CommonMarkConverter
+    {
+        $converter = new CommonMarkConverter([
+            'mentions' => [
+                'github_handle' => [
+                    'prefix' => '@',
+                    'pattern' => '[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}(?!\w)',
+                    'generator' => 'https://github.com/%s',
+                ],
+                'github_issue' => [
+                    'prefix' => '#',
+                    'pattern' => '\d+',
+                    'generator' => 'https://github.com/symfony/ux/issues/%d',
+                ],
+            ],
+        ]);
+
+        $converter->getEnvironment()
+            ->addRenderer(FencedCode::class, new CodeRenderer(), 10)
+            ->addExtension(new ExternalLinkExtension())
+            ->addExtension(new MentionExtension())
+        ;
+
+        return $converter;
+    }
+}

ux.symfony.com/src/Twig/Components/ChangelogItem.php

@@ -30,21 +30,12 @@ private function formatContent(string $content): string
         // Replace "## " with "### "
         $content = preg_replace('/^## /m', '### ', $content);
 
-        // Replace #1234 with a mardown link to the issue
-        $content = preg_replace('/#(\d+)/', '[#$1](https://github.com/symfony/ux/issues/$1)', $content);
+        // Replace "https://github.com/symfony/ux/pull/x" with "#x"
+        $content = preg_replace('#https://github.com/symfony/ux/pull/(\d+)/?#', '#$1', $content);
 
-        // Replace "in https://github.com/symfony/ux/pull/1234" with a mardown link to the PR
-        $content = preg_replace('#in https://github.com/symfony/ux/pull/(\d+)/?#', 'in [#$1](https://github.com/symfony/ux/issues/$1)', $content);
-
-        // Replace "https://github.com/symfony/ux/compare/v2.14.1...v2.14.2" with a mardown link to the full changelog
+        // Replace "https://github.com/symfony/ux/compare/v2.14.1...v2.14.2" with a markdown link to the full changelog
         $content = preg_replace('#(https://github.com/symfony/ux/compare/(v(\d+\.\d+\.\d+))...(v(\d+\.\d+\.\d+)))#', '[$2 -> $4]($1)', $content);
 
-        // Insert markdown link to the user's Github profile
-        // ...in: "by @weaverryan in "
-        $content = preg_replace('/by @([a-zA-Z0-9_]+) in /', 'by [@$1](https://github.com/$1) in ', $content);
-        // ...in: "@weaverryan made their first "
-        $content = preg_replace('/@([a-zA-Z0-9_]+) made their first /', '[@$1](https://github.com/$1) made their first ', $content);
-
         // Shorten "made their first contribution in" to "in"
         $content = preg_replace('/made their first contribution in/', 'in', $content);
 

ux.symfony.com/tests/Twig/Components/ChangelogItemTest.php

@@ -52,14 +52,6 @@ public static function provideContentValues(): iterable
             '### Title 3',
             '### Title 3',
         ];
-        yield 'inject_#issue_link' => [
-            'Fixes #1234',
-            'Fixes [#1234](https://github.com/symfony/ux/issues/1234)',
-        ];
-        yield 'inject_@user_link' => [
-            'by @weaverryan in ',
-            'by [@weaverryan](https://github.com/weaverryan) in ',
-        ];
         yield 'inject_changelog_link' => [
             'https://github.com/symfony/ux/compare/v2.14.1...v2.14.2',
             '[v2.14.1 -> v2.14.2](https://github.com/symfony/ux/compare/v2.14.1...v2.14.2)',