[Site] fix: AppHeader top spacing on mobile #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebMamba
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thanks @raphael-geffroy for this fast PR!
Looks like this is working great, now!
@smnandre any objection on the syntax use here? I didn't know about it
carsonbot
added
Status: Reviewed
|
@raphael-geffroy could you remove the |
smnandre
approved these changes
Apr 10, 2024
raphael-geffroy
changed the title
|
Thanks again Raphaël! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Banner caused the an unwanted space for the opened AppHeader on mobile. This PR tries to fix this by undisplaying the Banner when the AppHeader is open.