[Twig] CVA - Rework implementation + documentation #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
reviewed
Mar 25, 2024
carsonbot
added
Status: Reviewed
2 tasks
kbond
approved these changes
Apr 9, 2024
carsonbot
added
Status: Reviewed
kbond
force-pushed
the
dx/cva-another-implementation
branch
from
2f6260a to
1301956
Compare
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try another implementation + add some tests.
Updated/added a lot of documentation in the CVA class.
All tests are green but i'm not 100% sure this made no change at all :|
@WebMamba I let you decide what you want to do with it (i needed a class to test some things :) ) .. really open to any choice :)
@kbond that does not include your modifications i think :|