Skip to content

[TwigComponent] Register safe classes in the configurator #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Mar 3, 2024

Q A
Bug fix? no
New feature? no
Issues Fix
License MIT

(+ some minor CS)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 3, 2024
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing 1 phpcs detail - but very nice idea!

@carsonbot carsonbot added Status: Needs Work Additional work is needed Status: Needs Review Needs to be reviewed and removed Status: Needs Review Needs to be reviewed Status: Needs Work Additional work is needed labels Mar 5, 2024
@smnandre smnandre force-pushed the safe-classes-configurator branch from cd5f46d to e32adaf Compare March 5, 2024 18:21
@smnandre
Copy link
Member Author

smnandre commented Mar 5, 2024

Just missing 1 phpcs detail - but very nice idea!

Good 😅

@weaverryan weaverryan force-pushed the safe-classes-configurator branch from 2266990 to 186b216 Compare March 6, 2024 17:11
@weaverryan
Copy link
Member

Thanks Simon!

@weaverryan weaverryan merged commit 6adae60 into symfony:2.x Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants