Skip to content

[Icons] Website Icon search (beta) #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Mar 2, 2024

We decided to postpone / delay a couple of cool features to focus on a smaller & cleaner first version.

I know i'll have a lot of cleaning / CSS fixes et (no need to review them all haha), but i really would like to do this once it's all agreed about design / features, etc :)

Thanks @kbond for the support despite the delays :)

icons

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 2, 2024
@smnandre smnandre force-pushed the site/ux-icons branch 2 times, most recently from 4874a01 to fd62378 Compare March 2, 2024 16:45
@smnandre smnandre changed the title [Icons] Website Icon search [Icons] Website Icon search (beta) Mar 2, 2024
@kbond
Copy link
Member

kbond commented Mar 2, 2024

Awesome work @smnandre! This is a companion of #1450

@kbond
Copy link
Member

kbond commented Mar 2, 2024

We should add Powered by Iconify Design somewhere.

@smnandre
Copy link
Member Author

smnandre commented Mar 3, 2024

We should add Powered by Iconify Design somewhere.

Yep good idea

Capture d’écran 2024-03-03 à 02 06 52

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only started reviewing - eager to play with things!

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Mar 7, 2024
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Mar 8, 2024
@smnandre
Copy link
Member Author

smnandre commented Mar 8, 2024

Seems good

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 20, 2024
@kbond
Copy link
Member

kbond commented Mar 20, 2024

!!!!!

@kbond kbond merged commit 2a64f54 into symfony:2.x Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants