Skip to content

Update CVA docs and fixes #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Conversation

WebMamba
Copy link
Contributor

@WebMamba WebMamba commented Mar 1, 2024

Q A
Bug fix? no
New feature? no
Issues
License MIT

@weaverryan asked for a few changes here: #1416.
So here are the fixes. 😁

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 1, 2024
@WebMamba WebMamba force-pushed the update_cva_doc_and_fixes branch from 9a321d2 to 7178c3f Compare March 1, 2024 09:48
@WebMamba WebMamba force-pushed the update_cva_doc_and_fixes branch from 7178c3f to 057d68b Compare March 1, 2024 09:50
Co-authored-by: Kevin Bond <kevinbond@gmail.com>
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 1, 2024
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few tweaks - thanks for the fast PR!

@weaverryan
Copy link
Member

Thanks Matheo!

@weaverryan weaverryan merged commit 2ddc47b into symfony:2.x Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants