Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StimulusBundle/TwigComponent] Fix "use_yield" to "true" deprecation notice in CI #1478

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

evertharmeling
Copy link
Contributor

@evertharmeling evertharmeling commented Feb 8, 2024

Q A
Bug fix? yes
New feature? no
Issues
License MIT

Only this one remains (in StimulusBundle), but I can't find a direct implementation related to the Environment in that test. Maybe also related to symfony/symfony#53805 or thoughts anyone?

1x: Since twig/twig 3.9.0: Not setting "use_yield" to "true" is deprecated.
    1x in StimulusControllerLoaderFunctionalTest::testFullApplicationLoad from Symfony\UX\StimulusBundle\Tests\AssetMapper

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 8, 2024
@evertharmeling evertharmeling changed the title [StimulusBundle] Fix CI (partly) [StimulusBundle/TwigComponent] Fix "use_yield" to "true" deprecation notice in CI Feb 8, 2024
@weaverryan
Copy link
Member

Thanks @evertharmeling! We'll keep debugging the rest after this. For the TwigComponents deprecation, more work is needed - and I know that Simon has looked into it #1390 (comment)

@weaverryan
Copy link
Member

Thanks Evert!

@weaverryan weaverryan merged commit 33c66f3 into symfony:2.x Feb 9, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants