minor(live): add security tests #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
|
Thanks Kevin! |
|
They fails on PHP 8.1 with old version of security: https://github.com/symfony/ux/actions/runs/7849800864/job/21423912123 Should we fix... or increase min version of security bundle ? @kbond ? |
|
I think I'm find bumping the dev dependency. It saves a bunch of extra compat code in the test fixtures and it should all still work in the old security system. @weaverryan, wdyt? |
weaverryan
added a commit
that referenced
this pull request
Feb 21, 2024
…ond) This PR was squashed before being merged into the 2.x branch. Discussion ---------- feat(live): improve `TestLiveComponent::actingAs()` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT _(depends on #1460)_ Currently, if you have a component that requires authentication for all actions (ie `#[IsGranted]` on the component class), in your tests, as soon as you call `$this->createLiveComponent(...)`, you'll get an access denied exception. You never get a chance to call `->actingAs()`. This PR makes the initial request for the live component _lazy_. Only when the initial request is required (for other methods), is it made. This gives you the chance to call `->actingAs()` before the initial render. Commits ------- d0a4713 feat(live): improve `TestLiveComponent::actingAs()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some security-related tests:
IsGrantedat the class level is respected.#[CurrentUser]can be injected into actions/listeners.