[ChartJs] Remove <3.9 boundary and fix testsuite #1433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snugged in with #1518 |
weaverryan
added a commit
that referenced
this pull request
Feb 26, 2024
…armeling) This PR was merged into the 2.x branch. Discussion ---------- [ChartJs] Remove <3.9 boundary in devDependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Follow up on #1518 (more info in #1433) | License | MIT Commits ------- d2836a9 [ChartJs] Remove <3.9 boundary and fix testsuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1013 the version of
chartjswas restricted to<3.9and since adjusting the test script in #1417 (and later merging #1389) it seemed that version constraint notation^3.4.1 <3.9wasn't supported (see) by it. I tried supporting the boundary condition but it turned into quite the rabbit hole correctly parsing it and keeping it simple/pragmatic.If I understand correctly, issue #1013, introduced the boundary condition because it was related to our testsuite, since that has been fixed in #1202. It looks like we therefor can drop the upper boundary again. I'm not sure if we cover the issue in our testsuite, but our testsuite passes on
chartjs@3.9.1.So the removal of the boundary introduces:
chartjsversions^3.4.1and^4.0Cheers!