Skip to content

[Site] Make package box titles visible in dark mode #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[Site] Make package box titles visible in dark mode #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ux.symfony.com/assets/styles/components/_PackageBox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@
letter-spacing: -1px;
color: #0A0A0A;
text-decoration: none;

[data-bs-theme="dark"] & {
filter: invert(1);
}
}
Comment on lines 121 to 127
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

color: var(--bs-body-color);
text-decoration: none;

Simpler no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Depends" ;) If you mean to change it on line 121, then it will be changed to a light theme.

I followed already used code from: https://github.com/symfony/ux/blob/2.x/ux.symfony.com/assets/styles/sections/_header.scss#L39

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i wanted to invert all the colors, but if you look on other CSS properties, i tried to use CSS vars as much as possible because it's easier to read/maintain..

But i won't go against your suggestion :)) Iit's a good catch and a really nice attention to open this PR, and i'm really glad you did :)


.PackageBox_link {
Expand Down