[LiveComponent] Add a required "default" action for live components #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 1, 2021
kbond
force-pushed
the
default-action
branch
2 times, most recently
from
48117f4 to
c335326
Compare
weaverryan
reviewed
Jul 6, 2021
weaverryan
approved these changes
Jul 7, 2021
weaverryan
force-pushed
the
default-action
branch
from
86ab5ae to
04d355f
Compare
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the
@Security/@Cacheannotations for your components, we need the default action to be on the component itself. Currently, for the default action, the component is wrapped inside an internal callableDefaultComponentControllerobject. This won't inherit these annotations from the component class. The best solution @weaverryan and I could think of is to enforce a "default action" method exists on your component itself.By default,
__invoke()is used but this can be customized via theAsLiveComponent::$defaultActionproperty. ADefaultActionTraitis provided that just adds an empty__invoke()method.