Fix option tag synchronization #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THANK you for hunting this down! Do you think you could add a test for it - maybe in https://github.com/symfony/ux/blob/2.x/src/LiveComponent/assets/test/controller/render.test.ts you can set up a situation that exposes the bug? |
|
great job <3 |
|
No problem I will add a test and in the same time fix the failed check |
|
All done ! ;) |
|
Absolutely gorgeous - thank you Denis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
morphdom need to synchronize all
optiontags of aselectto set theselectedattribute on the good tag and then set the rightselectedIndexon the parentselecttag. See #960 for an illustration of the bug.