[LiveComponent] Error on Vector props hydratation

[Nek-]

I'm using php-ds. But it seems to be highly unsupported by symfony ux. It's really complicated to have something working with. But here is something that looks more like an error to me than something unsupported. Issues with Doctrine collections may be connected.

Here is an example of a component:

class Options
{
    // a vector because they are ordered, it avoids storing the order elsewhere or weird array manipulation
Opt
    /** @var Vector<Option> */
    #[LiveProp(useSerializerForHydration: true, serializationContext: ['groups' => self::SERIALIZATION_GROUP])]
    public Vector $selectedOptions;
}

Looks ok isn't it? Yep, but it does not work. Because the LiveComponentHydrator transforms the type Vector to Option[], you guess the rest: it results in an array, an array is not a Vector, so it fails.

Here is the location of the error:

ux/src/LiveComponent/src/LiveComponentHydrator.php

Lines 268 to 272 in 6b8b305

	if (Type::BUILTIN_TYPE_OBJECT === $builtInType) {
	$type = $propMetadata->collectionValueType()->getClassName().'[]';
	} else {
	$type = $builtInType.'[]';
	}

Not sure how you want to fix this, it looks not easy.

[smnandre]

Hi @Nek- .. did you try with a custom hydration extension ?

https://symfony.com/bundles/ux-live-component/current/index.html#hydration-extensions

[Nek-]

@smnandre yes, but it does not work because it does not work like the serializer: I need a vector hydration extension but it needs to hydrate the content as well and cannot use the doctrine hydration extension (it's internal!). AFAIK hydration extensions do not cascade well like the normalizers does. I ended up with an array.

[smnandre]

How would you fix this ? What i get here is that the propertyinfo consider your var as a collection, right ?

[Nek-]

The issue is very specific on this else:

ux/src/LiveComponent/src/LiveComponentHydrator.php

Line 270 in 6b8b305

} else {

It needs to be an elseif ($type == 'array') { $type = .. '[]'; } else { $type = $propMetadata->getType();} (smth like that)

[smnandre]

If it's a collection, we need to specify the "children" type (tha'ts the idea of the [] notation). Else, serializer must know how to handle it.

So i think this should return false

            if ($propMetadata->collectionValueType()) {

ux/src/LiveComponent/src/LiveComponentHydrator.php

Line 266 in 6b8b305

if ($propMetadata->collectionValueType()) {

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!