[LiveComponent] Setting custom live-id in template not working anymore (since 2.14)

[tijnema]

Hi,

We've been generating a custom live-id inside components for a while now, which fixes a lot of reloading issues (including #1470 ). Since release 2.14 however, this no longer works as expected.

I've created a reproducer project: https://github.com/tijnema/livebug2
Currently it is running with live components 2.13, pressing the button will reload the parent (render time will update), and childs are not being updated.
When upgrading the reproducer to 2.14, clicking the rerender button will reload all 100 child components (see the 102 network request in debug bar).

We set the live-id in the template like this:

<div {{ attributes.without('data-live-id').defaults({'data-live-id': this.liveId}) }}>

I haven't found a better way to set the live-id inside a component (docs mention only setting it as argument when creating the component).
Maybe live components can have a method for generating a live id?

[smnandre]

Same thing here... i see no problem here after installing your reproducer (or upgrading to 2.14.2)

Enregistrement.de.l.ecran.2024-02-07.a.21.29.11.mov

[tijnema]

Screencast_20240207_214931-1.webm

[smnandre]

Maybe it's related to other packages ? Did you upgrade all ux packages ?

[tijnema]

I tried upgrading ux-live-component only, and with composer -W option, which updated ux-twig-component too, but it makes no difference.

I've installed the reproducer on a dev server here: http://livebug2.tijnema.com/

All I've done is:

git clone https://github.com/tijnema/livebug2
cd livebug2
composer require symfony/ux-live-component="v2.14.2" -W

[smnandre]

I upgraded all, that could be a solution

[tijnema]

What other packages are you talking about? I ran composer update once more, and that doesn't update anything.

Just to be sure it's not browser related, can you see the issue on the link I provided?

[smnandre]

I did and i saw the bug you described

[smnandre]

Could you update symfony/ux-twig-component and symfony/stimulus-bundle to 2.14.2 just to see if that can be related ?

(the only thing i see that seems to be different between my working test and yours )

[tijnema]

They are at version 2.14.2 right now, doesn't make any difference.

[smnandre]

I have now the bug locally oO ... will investigate from there.

[smnandre]

The following code would do what you expect i think

(working on my machine, but as we just saw.... it's not something we can base anything on haha)

{# child.html.twig #}
<div {{ attributes.defaults({'key': this.liveId})  }}>
    <strong>Hello, I'm {{ this.number }}</strong><br>
</div>

[tijnema]

This works on my machine too, because it does not actually update the live-id used.

It's actually the same as:

{# child.html.twig #}
<div {{ attributes  }}>
    <strong>Hello, I'm {{ this.number }}</strong><br>
</div>

But for me to fix other issues, like #1470 , I need to be able to set the live-id .