[Translator] Filter dumped locales

[stof]

Currently, the translation dumper dumps all translations for all locales. However, in some projects, we have a list of locales we support and we don't care about others (which might still have keys defined for the third-party translations).

It would be great to filter the list of dumped translations based on the kernel.enabled_locales parameter defined in FrameworkBundle.

[jmsche]

Hi stof,

Maybe I'm wrong, but in a project with framework.enabled_locales set, I don't seem to have all locales dumped, only the ones defined in this configuration key.

[stof]

maybe this already works thanks to a filtering done in FrameworkBundle (as this bundle relies on FrameworkBundle to load translations).
But then, it might make sense to at least add a functional test for this, to prevent regressions.

[Kocal]

Hi, this feature is already presents, it uses the TranslatorBagInterface#getCatalogues() as source of truth (

ux/src/Translator/src/CacheWarmer/TranslationsCacheWarmer.php

Line 39 in 262db2b

...$this->translatorBag->getCatalogues()

), but indeed there is not functional tests ATM.

I can try to add one asap.

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Friendly reminder that this issue exists. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

[Kocal]

Tests mentioned in #1226 (comment) still need to be added I guess

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!